Refactor the spec to allow non-network transports #996
+104
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
orkon/transports
branch
5 times, most recently
from
9b7d68a to
d067db3
Compare
OrKoN
force-pushed
the
orkon/transports
branch
from
d067db3 to
ed27887
Compare
OrKoN
changed the title
| text: %x1 denotes a text frame; url: section-5.2 | ||
| text: Send a WebSocket Message; url: section-6.1 | ||
| text: A WebSocket Message Has Been Received; url: section-6.2 | ||
| text: a WebSocket Message Has Been Received; url: section-6.2 |
There was a problem hiding this comment.
nit: I don't think it is case-sensitive, so no need it this change.
sadym-chromium
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't know of a good example of a spec polymorphism so attempted to rewrite as I saw fit.
Related: #731
Preview | Diff