Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specification for loading extensions in WebDriver Classic #760

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kiaraarose
Copy link

Preview available here

@kiaraarose kiaraarose marked this pull request as ready for review February 3, 2025 22:49
specification/webdriver-classic.bs Outdated Show resolved Hide resolved
specification/webdriver-classic.bs Outdated Show resolved Hide resolved
@kiaraarose kiaraarose force-pushed the main branch 2 times, most recently from f3bc5e3 to d20128c Compare February 4, 2025 18:52
@Rob--W
Copy link
Member

Rob--W commented Feb 4, 2025

The spec proposed endpoints taking {extension id} in the URL.

What is the format of extension id? (if provided externally, how about URL encoding and such?)

How does the caller know the extension ID? That is unspecified.

@xeenon
Copy link
Collaborator

xeenon commented Feb 4, 2025

How does the caller know the extension ID? That is unspecified.

It is the result of the load command:

  1. Let result be the identifier of the loaded extension.
  2. Return success with result.

What is the format of extension id? (if provided externally, how about URL encoding and such?)

I think it can be an opaque URL path compatible string, even just a monotonic increasing integer would do.

@kiaraarose
Copy link
Author

I think it can be an opaque URL path compatible string, even just a monotonic increasing integer would do.

The extension identifier is the same format of what's returned in Safari. It matchesbrowser.runtime.id

Copy link
Member

@oliverdunk oliverdunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally this looks good. I've left a couple of comments following our call earlier to clarify the purpose of this document and the relationship to WebDriver BiDi :)

specification/webdriver-classic.bs Show resolved Hide resolved
specification/webdriver-classic.bs Show resolved Hide resolved
specification/webdriver-classic.bs Outdated Show resolved Hide resolved
Copy link
Member

@oliverdunk oliverdunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kiara!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants