Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Add tabGroups.tabGroup.shared #761

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Proposal: Add tabGroups.tabGroup.shared #761

wants to merge 6 commits into from

Conversation

dpenning
Copy link

@dpenning dpenning commented Feb 4, 2025

proposal introducing shared state. see issue #749

oliverdunk
oliverdunk approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@oliverdunk oliverdunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments, but this largely matches the issue which we are all supportive of. Thanks for opening this.

proposals/tab_group_shared_state.md Show resolved Hide resolved
proposals/tab_group_shared_state.md Outdated Show resolved Hide resolved
proposals/tab_group_shared_state.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverdunk oliverdunk oliverdunk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dpenning @oliverdunk