fix(Dockerfile): initialize git repo in VMAF source to satisfy vcstagger #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initialize a minimal git repository after extracting the VMAF tarball so that Meson’s git describe step works properly. This prevents the fatal error due to missing .git data.
|
Hi, could you elaborate more? i'm a bit confused as it seems to build fine as it is. But i do see this in the build log but it seem to not fail the build? but maybe some version string ends up wrong or empty because of it, but is that string exposed somewhere via the ffmpeg cli tools? For what i can see vmaf does not do "proper" source distributions of releases that embed the version? the "source code" link on github will download a git tag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR fixes the build error in the Dockerfile by initializing a minimal git repository in the VMAF source directory. The issue occurred during the Meson step (vcstagger) because the tarball lacked a .git folder.
Changes:
Testing:
I built the image locally (using Podman on an Apple M3 Pro) and confirmed that the build now completes successfully without errors.