Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Wagtail 6.3 #96

Merged
merged 5 commits into from
Nov 20, 2024
Merged

Update for Wagtail 6.3 #96

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
924847c
update tox setup
JakubMastalerz Nov 18, 2024
528e273
add Django 5.1 and Python 3.13 to tox tests
JakubMastalerz Nov 18, 2024
3455733
update github workflow
JakubMastalerz Nov 19, 2024
4ea4529
update changelog
JakubMastalerz Nov 19, 2024
a685634
drop support for Python 3.8
JakubMastalerz Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/python-tox.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:

strategy:
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]

We probably don't need 3.8 any longer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure about this. On one hand, python 3.8 has reached end-of-life. On the other, it is listed as compatible with Wagtail 5.2. My instinct was to wait until 5.2 becomes deprecated to remove it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropped 3.8 in a685634


steps:
- uses: actions/checkout@v4
Expand Down
4 changes: 4 additions & 0 deletions CHANGES
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
Unreleased
==========

- Update for Wagtail 6.3
- Add support for Python 3.13
- Drop support for Wagtal 6.0 and 6.1

4.2.1
=====
- Update setup.py for PyPI compatibility
Expand Down
1 change: 1 addition & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
"Programming Language :: Python :: Implementation :: CPython",
"Programming Language :: Python :: Implementation :: PyPy",
"Framework :: Django",
Expand Down
11 changes: 7 additions & 4 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
[tox]
minversion = 3.21.4
envlist =
py{38,39,310,311}-django42-wagtail{52,60,61}-factoryboy{32,33}
py{310,311,312}-django50-wagtail{60,61}-factoryboy{32,33}
py{38,39,310,311}-django42-wagtail{52,62}-factoryboy{32,33}
py{310,311,312}-django50-wagtail{52,62,63}-factoryboy{32,33}
py{310,311,312,313}-django51-wagtail63-factoryboy{32,33}
coverage-report
lint

Expand All @@ -13,16 +14,18 @@ python =
3.10: py310
3.11: py311
3.12: py312
3.13: py313

[testenv]
commands = coverage run --parallel -m pytest {posargs}
extras = test
deps =
django42: django>=4.2,<5.0
django50: django>=5.0,<5.1
django51: django>=5.1,<5.2
wagtail52: wagtail>=5.2,<6.0
wagtail60: wagtail>=6.0,<6.1
wagtail61: wagtail>=6.1,<6.2
wagtail62: wagtail>=6.2,<6.3
wagtail63: wagtail>=6.3,<6.4
factoryboy32: factory-boy>=3.2,<3.3
factoryboy33: factory-boy>=3.3,<3.4

Expand Down