Repository navigation
expose v3 ios native tab functions to wails ios api - #6169
nimaeskandary wants to merge 1 commit into
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configurationConfiguration used: Repository: wailsapp/wails/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: wailsapp/wails/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (10)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. WalkthroughThe iOS runtime adds methods to enable, query, and select native tabs. The TypeScript runtime exposes these methods, and the iOS example and guide show how to use them. ChangesiOS Native Tabs
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant ExampleFrontend
participant IOS.NativeTabs
participant processIOSMethod
participant iosManager
ExampleFrontend->>IOS.NativeTabs: Select(1)
IOS.NativeTabs->>processIOSMethod: Invoke method ID 11 with index 1
processIOSMethod->>iosManager: SelectNativeTab(1)
Merge Risk: ⚪ Minimal · up to The iOS example uses the updated native-tab controls through its local runtime build. No issue identified here needs to be fixed before merge. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Full details: Description checkExplanation The description explains the feature, motivation, testing environment, implementation type, and checklist status. However, this new feature does not link an accepted WEP PR as required by the repository template, and the issue reference remains unresolved. Full details: Docstring CoverageExplanation Docstring coverage is 26.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 15 functions across 6 files. (2 skipped: 2 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit taps the tab with care Comment |
3a180f0 to
863ad65
Compare
Description
Hi wails maintainers. This PR is to expose the native tab controls on ios via the wails3 ios api, namely:
Today, you can only configure native tabs to be enabled globally via the ios config, you can't disable them for certain views. The usecase I have is, some app views, I do not want the native tabs to show. Additionally, you can set the active tab by clicking on a tab icon, this PR allows you to also do this programmatically via tab index
I updated the ios example app to include these controls:
native-tabs-example.mov
llm notice
codex was used to assist with this PR
Fixes # (issue)
No issue made, let me know if you'd rather I start there.
Type of change
Please select the option that is relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration using
wails doctor.If you checked Linux, please specify the distro and version.
Test Configuration
Please paste the output of
wails doctor. If you are unable to run this command, please describe your environment in as much detail as possible.Checklist:
website/src/pages/changelog.mdxwith details of this PR (v3 changelog entries are added automatically)Summary by CodeRabbit