Repository navigation
feat(v3/updater): add Config.OnUpdateApplied for post-update bookkeeping - #6202
Draft
AlbinoGeek wants to merge 3 commits into
Draft
AlbinoGeek wants to merge 3 commits into
AlbinoGeek wants to merge 3 commits into
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
4 of 16 tasks
AlbinoGeek
force-pushed
the
feat/v3-updater-on-update-applied
branch
from
October 4, 2026 07:13
981884b to
465e734
Compare
AlbinoGeek
force-pushed
the
feat/v3-updater-on-update-applied
branch
from
October 6, 2026 05:57
465e734 to
40ce22b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
WEP: #6203
Apps had no hook for post-update bookkeeping, such as refreshing an NSIS
DisplayVersion.Config.OnUpdateApplied(previousVersion)is called once fromIniton the first launch afterRestartreplaced the app. The helper passes the replaced version via a temp-dir marker keyed by the target path, so it works throughopen -non macOS where environment variables do not survive.Type of change
How Has This Been Tested?
Added tests in
helper_test.goandupdater_test.gofor the marker round trip and the once-only callback.cd v3 && go test ./pkg/updater/... && go vet ./pkg/updater/...pass on this branch alone;gofmt -lon the changed files is empty.Test Configuration
Fedora Linux 44 Workstation, amd64, GNOME on Wayland. Only the
pkg/updaterunit tests were run for this change, so nowails doctoroutput applies.Checklist:
website/src/pages/changelog.mdxwith details of this PR (v3 changelog entries are added automatically)An entry is added to
v3/UNRELEASED_CHANGELOG.mdand the updater guide is updated.This adds public API (a new optional config field, non-breaking), so it follows the WEP process: the proposal is #6203. This PR is its draft reference implementation and stays in draft until the WEP is decided.
Overlap with sibling PRs: this is one of three independent updater PRs from the same author (EXDEV staging, AppImage self-path,
OnUpdateApplied). Each branch is based on master and passes on its own. They touch the same files in a few places (spawn.go,helper.go,updater.go, the guide, and the changelog), including the smallresolveTargethelper that two of them also add, so whichever merges second may need a trivial textual rebase.The code and this description were written with an AI assistant (Claude). I reviewed the diff and ran the tests listed above.