Repository navigation
Conversation
Signed-off-by: Martin Gysel <me@bearsh.org>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. WalkthroughThe Linux GTK file chooser now accepts an initial filename. The open dialog passes an empty filename, and the save dialog passes its requested filename. ChangesLinux file chooser
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The Linux save dialog can start with the requested filename, including for a new file. No material merge-blocking issue remains. Architecture SummaryArchitecture risk: 🟡 Medium · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
Reliability and maintainability
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit peeks at the save dialog bright, Comment |
Description
On linux, the current implementation of the save file dialog does not support setting the initial filename.
So extend runChooserDialog() to accept the current filename as argument and set it not empty.
Type of change
Please select the option that is relevant.
How Has This Been Tested?
Locally tested on linux. The save as dialog gets started from js.
If you checked Linux, please specify the distro and version.
KDE Neon 24.02
Summary by CodeRabbit