Repository navigation
fix(v3/windows): add FileVersion to the default info.json - #6245
happy666End wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. WalkthroughThe Windows asset metadata template now sets ChangesWindows asset version metadata
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The metadata addition and its test present no identified issue preventing merge after normal checks. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)✅ Passed checks (4 passed)Full details: Docstring CoverageExplanation Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the version string, Comment |
Description
The default
info.jsonhas noFileVersionstring, although the VERSIONINFO docs list it as required. SignPath won't sign such an exe when the signing policy checks the product name. The error isThe file has an unexpected product name '', even thoughProductNameis set.I ran into this while setting up signing for a Wails app. A hello world built with the current template fails that check, and the same exe with
FileVersionadded gets signed.The template now sets
FileVersionto the product version. Existing projects get it withwails3 update build-assets.There's no open issue for this.
Type of change
How Has This Been Tested?
TestWindowsInfoJSONgenerates the build assets and checks the Windows string table forFileVersion. It fails without the template change, andgo test ./internal/commands/passes.The SignPath check ran on GitHub Actions against their test certificate, with
wails3 generate sysofrom v3.0.0-beta.16.Test Configuration
macOS 27.0 (arm64), Go 1.26.3, source checkout at ec0fb83.
Checklist:
Summary by CodeRabbit