Skip to content

fix(v3/windows): add FileVersion to the default info.json - #6245

Open
happy666End wants to merge 1 commit into
wailsapp:masterfrom
happy666End:fix/windows-info-json-versioninfo
Open

happy666End wants to merge 1 commit into
wailsapp:masterfrom
happy666End:fix/windows-info-json-versioninfo

Conversation

@happy666End

@happy666End happy666End commented Oct 9, 2026 •

Copy link
Copy Markdown

Description

The default info.json has no FileVersion string, although the VERSIONINFO docs list it as required. SignPath won't sign such an exe when the signing policy checks the product name. The error is The file has an unexpected product name '', even though ProductName is set.

I ran into this while setting up signing for a Wails app. A hello world built with the current template fails that check, and the same exe with FileVersion added gets signed.

The template now sets FileVersion to the product version. Existing projects get it with wails3 update build-assets.

There's no open issue for this.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

TestWindowsInfoJSON generates the build assets and checks the Windows string table for FileVersion. It fails without the template change, and go test ./internal/commands/ passes.

The SignPath check ran on GitHub Actions against their test certificate, with wails3 generate syso from v3.0.0-beta.16.

  • Windows
  • macOS
  • Linux

Test Configuration

macOS 27.0 (arm64), Go 1.26.3, source checkout at ec0fb83.

Checklist:

  • My code follows the general coding style of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Summary by CodeRabbit

  • Bug Fixes
    • Windows build assets now include the product version in their file metadata across language tables.

@github-actions github-actions Bot added Bug Something isn't working v3 cli labels Oct 9, 2026
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: wailsapp/wails/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 79e03a9e-cc7a-4433-927a-577e28116bac

📥 Commits

Reviewing files that changed from the base of the PR and between ec0fb83 and 6eebb01.


📒 Files selected for processing (2)
  • v3/internal/commands/build-assets_test.go
  • v3/internal/commands/updatable_build_assets/windows/info.json.tmpl

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.



Walkthrough

The Windows asset metadata template now sets FileVersion from ProductVersion. A build-assets test checks that generated language tables contain the expected version.

Changes

Windows asset version metadata

Layer / File(s) Summary
Add and verify FileVersion
v3/internal/commands/updatable_build_assets/windows/info.json.tmpl, v3/internal/commands/build-assets_test.go
The template adds FileVersion using ProductVersion. The test parses generated windows/info.json and checks that each language table has FileVersion set to 1.2.3.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: leaanthony

Merge Risk: ⚪ Minimal · up to 6eebb

The metadata addition and its test present no identified issue preventing merge after normal checks.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (1 skipped: 1… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title clearly describes the main change: adding FileVersion to the default Windows info.json template.
Description check Passed The description explains the problem, motivation, implementation, testing, affected platforms, and test configuration. It also identifies that no issue exists. Some optional checklist items and wails …

Full details: Docstring Coverage

Explanation

Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (1 skipped: 1 unsupported.)



  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR


  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the version string,
Through language tables, hop by hop.
The template sets the value,
The test confirms it’s right,
Then carrots mark the happy stop.

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working cli v3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant