Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP-IDF: Removed explicit esp_task_wdt_reset call #3330

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vikramdattu
Copy link

Why is esp_task_wdt_reset needed?:

  • If the task is running for longer without yielding, this leads to the task watchdog to trigger, then one should reset the task watchdog with the mentioned API.

Points under consideration while removing the call:

  • lws_service() function call is not unyielding, meaning, it does wait on socket select. Even if this function is called in a loop, it should be the caller's responsibility to yield or call esp_task_wdt_reset.
  • Rightly so, the examples here do yield calling taskYIELD
  • Calling esp_task_wdt_reset without calling esp_task_wdt_add has no real use and only leads benign errors.

 - Also removed some esp_wdt specific unnecessary header includes
@vikramdattu
Copy link
Author

cc @Harshal5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant