Make New File keybinding editable

[SkyNotSilent]

Description

Closes #12681.

This moves the existing New File action from a fixed-only binding to an editable keybinding so it appears in Settings -> Keybindings and can be assigned by the user. The binding remains unassigned by default, and it keeps the existing CustomAction::NewFile trigger so the File menu item and custom shortcut dispatch stay aligned.

Implementation notes:

• add a stable workspace:new_file binding name
• register New File via EditableBinding instead of FixedBinding
• keep the existing WorkspaceAction::NewCodeFile handler unchanged
• add a regression test that verifies New File is editable, has no default shortcut, and is still backed by CustomAction::NewFile

Linked Issue

• The linked issue is labeled ready-to-spec or ready-to-implement.
• Screenshots/video are included below because this is visible in Settings -> Keybindings.

Visual Evidence

Searching Settings -> Keyboard Shortcuts for New File now shows the entry, and selecting it opens the editable shortcut capture state.

Testing

• cargo fmt -p warp
• cargo test -p warp util::bindings::tests --lib
• git diff --check
• Manually tested with ./script/run by opening Settings -> Keyboard Shortcuts, searching New File, and selecting the row to verify the editable shortcut capture state.

Agent Mode

• Warp Agent Mode - This PR was created via Warp's AI Agent Mode

CHANGELOG-IMPROVEMENT: New File can now be assigned a custom keyboard shortcut from Settings -> Keybindings.

[SkyNotSilent]

/oz-review

[oz-for-oss]

@SkyNotSilent

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

@SkyNotSilent

I'm re-reviewing this pull request in response to a review request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

Overview

This PR moves the New File action from a fixed custom-action binding to an editable keybinding with no default shortcut, and adds a regression test for the registration.

Concerns

• This is a user-facing Settings -> Keybindings behavior change, but the PR does not include screenshots or a screen recording demonstrating that New File appears in Settings and can be assigned end to end. The repository review guidance requires visual evidence for user-visible changes, even when the implementation is mostly registration plumbing.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

Overview

This PR moves the New File action from a fixed custom action binding to an editable workspace:new_file binding with no default shortcut, while preserving the CustomAction::NewFile dispatch path and adding a regression test.

Concerns

• This is a user-facing Settings → Keybindings change, but the PR does not include screenshots or a screen recording demonstrating New File appearing/editing in Settings end to end. Unit tests do not replace the required visual evidence for UI-impacting changes.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[SkyNotSilent]

Visual evidence for the Settings -> Keyboard Shortcuts path: searching for New File now shows the row, and selecting it opens the editable shortcut capture state with Default, Cancel, and Save.

[SkyNotSilent]

/oz-review

[oz-for-oss]

@SkyNotSilent

I'm re-reviewing this pull request in response to a review request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

Overview

This PR moves the existing New File action from a fixed custom action binding to an editable binding, adds a stable workspace:new_file binding name, and adds a regression test for the editable registration.

Concerns

• The change is user-facing because it makes New File visible/editable in Settings -> Keybindings, but the PR does not include screenshots or a screen recording. The repo review guidance requires visual evidence for user-facing behavior, and unit tests/textual explanation do not replace it. Please attach screenshots or a short recording demonstrating the Settings -> Keybindings entry and assignment flow working end to end.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[SkyNotSilent]

/oz-review

[oz-for-oss]

@SkyNotSilent

I'm re-reviewing this pull request in response to a review request.

You can view the conversation on Warp.

I reviewed this pull request and requested human review from: @acarl005.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Oz no longer requests changes for this pull request after the latest automated review.

[oz-for-oss]

Overview

This PR moves the existing New File action from a fixed custom action binding to an editable workspace:new_file binding with no default shortcut, while preserving the CustomAction::NewFile dispatch path and adding a regression test for the editable registration.

Concerns

• No blocking correctness, security, or spec-alignment concerns found in the changed lines. No approved spec context was available for this PR.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz