Rework onboarding "Choose how to access AI": Subscription + Set up later

[jefflloyd]

Description

Reworks the "Choose how to access AI" onboarding slide (Warp Agent path), gated by OpenWarpNewSettingsModes. The slide now offers two options:

• Subscription — the paid plan, which kicks off the upgrade/checkout flow (browser open, manual auth-prompt fallback bar, Copy-URL / Paste-token links).
• Set up later — "Explore Warp's built-in AI features before committing to a plan, or bring your own inference."

Primary action moved onto Next. The in-card "Choose plan" button is removed; the bottom Next button drives the flow based on the selected card:

• Subscription selected → Next opens the upgrade page in the browser (and surfaces the fallback bar); if the user is already a paying user it advances. The slide still auto-advances once billing flips to paying.
• Set up later selected → Next advances to the next slide (skippable without subscribing).

All bring-your-own-key/endpoint (BYOK) code is removed: the add-key / add-custom-endpoint buttons, their actions/events, the "connected keys" status line, and the set_byok_status plumbing across the onboarding view and root_view. The now-orphaned provider_keys_modal (BYOK "Add API key" dialog) is deleted. The settings page's CustomEndpointModal is intentionally untouched (still used by settings).

This slide's own "I don't want AI" escape button is also removed (the other slides' copies are handled in PR-B).

Why: part of the agent-onboarding rework — simplify AI access to a clear "subscribe now or explore first" choice, and let users proceed without subscribing.

Notes for the integrator

PR-C of a 4-PR split. Shared-file edits are localized:

• model.rs: renamed AiAccessChoice::Byok → SetUpLater. Also removed the now-unused NoAiConfirmationSource::AiAccess variant + its single cancel_no_ai arm (authorized bounded exception; removing this slide's no-AI trigger orphaned it under -D warnings). Expect a small localized conflict with PR-B here, resolved at integration (merge order B→C).
• agent_onboarding_view.rs / bin/main.rs: removed the BYOK event variants.
• Did not touch the LoginSlideView::new call sites (owned by PR-D).

Conversation: https://staging.warp.dev/conversation/23cf4d0f-2950-4c25-a229-37c9715cf2c3
Run: https://oz.staging.warp.dev/runs/019efa09-3960-738c-965a-d4ccfea2a0f0

Linked Issue

N/A — tracked by the onboarding rework plan.

Testing

• ./script/format — clean

• cargo clippy -p onboarding --all-targets --all-features --tests -- -D warnings — clean

• cargo nextest run -p onboarding — 13/13 pass

• cargo clippy -p warp --all-targets --tests -- -D warnings — clean (default features; --all-features is blocked by an unrelated command-signatures-v2 yarn/corepack environment issue that WARP.md special-cases)

• cargo nextest run -p warp -E 'test(onboarding) | test(login)' — pass

• I have manually tested my changes locally with ./script/run

Agent Mode

• Warp Agent Mode - This PR was created via Warp's AI Agent Mode

CHANGELOG-IMPROVEMENT: The onboarding "Choose how to access AI" step now offers "Subscription" or "Set up later" and can be skipped without subscribing; choosing Subscription and pressing Next opens the upgrade page directly.

[oz-for-oss]

@jefflloyd

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

Overview

This PR reworks the onboarding AI access slide to replace the BYOK option with Subscription / Set up later, moves the subscription checkout trigger to Next, and removes the now-unused BYOK onboarding modal and event plumbing.

Concerns

• For this user-facing onboarding change, please include screenshots or a screen recording demonstrating the updated Subscription and Set up later flows end to end. The PR description does not include visual evidence, and the manual testing checkbox is still unchecked, so the UI behavior and fallback bar cannot be reviewed visually.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz