Spec: Add shell commands to the TUI up-arrow history menu (CODE-1906)#14192
Draft
warp-dev-github-integration[bot] wants to merge 4 commits into
Draft
Spec: Add shell commands to the TUI up-arrow history menu (CODE-1906)#14192warp-dev-github-integration[bot] wants to merge 4 commits into
warp-dev-github-integration[bot] wants to merge 4 commits into
Conversation
Extend the TUI up-arrow history menu (currently prompts-only per CODE-1871) to also surface executed shell commands, reusing the shared up_arrow_suggestions_for_terminal_view combiner. Opens in both shell and agent modes; accepting a command executes it as a shell command. Co-Authored-By: Oz <oz-agent@warp.dev>
…y scope) Address requester (harry) review feedback on the CODE-1906 spec: 1. Make explicit that dependent settings (include_agent_commands_in_history, ignored-suggestions, AI gates) are SHARED across GUI and TUI via the shared up_arrow_suggestions_for_terminal_view combiner — no TUI-only duplicates. 2. Command rows use the same ! prefix the TUI transcript uses for shell-command rows, in the transcript's bold bright-green prefix color, with NO tinted row background (replaces the earlier $ affordance proposal). 3. linked_workflow_data lives on the Command variant of TuiHistoryItemKind only (prompts have no linked-workflow data), not on the shared TuiHistoryItem. 4. Code identifiers use PromptAndCommandHistory (not the bare 'History'); UI/display copy keeps 'History'. 5. Strictly TUI-only — explicitly excludes all GUI menus including cloud-mode-v2. 6. Confirmed one interleaved list (prompts and commands in a single list). Co-Authored-By: Oz <oz-agent@warp.dev>
harryalbert
force-pushed
the
factory/code-1906-shell-commands-in-up-arrow-history-menu
branch
from
July 23, 2026 19:25
6e8116f to
1328198
Compare
Contributor
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Spec for CODE-1906: add executed shell commands to the Warp TUI up-arrow history menu, which today surfaces only agent prompts (the shell-command scope that CODE-1871 explicitly deferred). The menu will source both prompts and commands from the shared
up_arrow_suggestions_for_terminal_viewcombiner, open on Up in both!shell and agent modes, and execute a command when one is accepted.This PR currently contains only the spec under
.agents/specs/. The implementation will be added to this same PR/branch (the title and body will be updated to describe the shipped change at that point).Verification
Spec-only at this stage — no code changes yet. Implementation verification (unit tests,
./script/format --check,cargo clippy,cargo nextest run,./script/presubmit, and TUI visual proof) will be recorded here once the code lands.Key assumptions flagged for requester review (full detail in the spec's Open questions resolved):
crates/warp_tui/src/prompt_history_menu.rs(not the cloud-mode-v2 GUI menu, which is also prompts-only but behind theCloudModeInputV2dogfood flag).AcceptCommand).Originating thread: https://linear.app/warpdotdev/issue/CODE-1906/add-shell-commands-to-up-arrow-history-menu-right-now-it-just-has
This PR was generated with Oz.