Skip to content

Build authenticated recording viewer URL in client#14210

Merged
vkodithala merged 3 commits into
masterfrom
factory/quality-1193-open-recording-view-url
Jul 23, 2026
Merged

Build authenticated recording viewer URL in client#14210
vkodithala merged 3 commits into
masterfrom
factory/quality-1193-open-recording-view-url

Conversation

@warp-dev-github-integration

@warp-dev-github-integration warp-dev-github-integration Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Summary

StopRecording’s “Open recording” action now builds the authenticated Oz run viewer URL in the client from the ambient task ID, the recording artifact UID, and ChannelState::oz_root_url() from configuration:

{OzOrigin}/runs/{task_id}?artifact={artifact_uid}

The client no longer consumes the server-provided view_url field. If the conversation has no task ID, the existing signed download_url() path remains the fallback.

Verification

  • CARGO_HOME=/workspace/.cargo-home cargo test --manifest-path /workspace/warp/Cargo.toml -p warp --lib ai::blocklist::block::tests --no-fail-fast passed: 34 passed; 0 failed.
  • CARGO_HOME=/workspace/.cargo-home cargo check -p warp --lib passed.
  • CARGO_HOME=/workspace/.cargo-home ./script/presubmit passed Rust formatting, clippy, clang-format, and wgslfmt. Its test phase exited 100 because of broad environment-sensitive integration failures, including headless native recording unable to foreground a target window, SSH/password flows, unavailable 501 backend endpoints, API-key deserialization, and a port-9281 conflict. The affected blocklist tests passed.

UI verification status

WarpOss launched successfully with CARGO_HOME=/workspace/.cargo-home ./script/run. The authenticated Agent StopRecording banner could not be generated in this environment: onboarding required sign-in for Agent features, no authenticated recording/task artifact or debug link was available, and the ordinary Recording Mode/PTY Recording toggles do not create a StopRecording block. Therefore the “Open recording” click and destination could not be observed; no visual claim is made beyond the attached blocked-flow screenshot.

Computer-use screenshots

View screenshot: Warp OSS running unauthenticated in the terminal; recording toggles and the agent-conversation debug loader produced no StopRecording banner.

Related PR disposition

The server-side view_url response field is no longer needed because the client constructs the viewer URL locally. Please close warpdotdev/warp-server#13205 rather than retaining that dependency.

Originating thread: https://warpcommunity.slack.com/archives/C0BDQDW8V5E/p1784823046962819
Linear ticket: https://linear.app/warpdotdev/issue/QUALITY-1193/link-open-recording-in-the-stoprecording-blocklist-banner-to-the

CHANGELOG-BUG-FIX: Open recording artifacts in the authenticated viewer using the client-built Oz run URL.

This PR was generated with Oz.

Consume the optional server-provided view URL for recording artifacts while retaining the signed download URL fallback for older servers.

Co-Authored-By: Oz <oz-agent@warp.dev>
@cla-bot cla-bot Bot added the cla-signed label Jul 23, 2026
Use the configured Oz origin, ambient task ID, and recording artifact UID to open the authenticated run viewer directly. Keep signed downloads as a fallback and remove the unused server view_url dependency.\n\nCo-Authored-By: Oz <oz-agent@warp.dev>
@warp-dev-github-integration warp-dev-github-integration Bot changed the title Open recording artifacts in authenticated viewer Build authenticated recording viewer URL in client Jul 23, 2026
@warp-dev-github-integration
warp-dev-github-integration Bot marked this pull request as ready for review July 23, 2026 21:35
@oz-for-oss

oz-for-oss Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

@warp-dev-github-integration[bot]

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@oz-for-oss oz-for-oss Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR changes the StopRecording "Open recording" action to build an authenticated Oz run viewer URL in the client from the conversation task ID and recording artifact UID, with the existing signed download URL as the fallback when no task ID is available.

Concerns

  • The PR is user-facing, but the attached media only shows a blocked unauthenticated flow and does not demonstrate clicking "Open recording" and landing on the authenticated recording viewer end to end. Repo guidance requires visual evidence for user-visible behavior before merge.
  • No approved or repository spec context was available, so there were no spec commitments to validate against.
  • Security pass found no issues.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@vkodithala vkodithala left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkodithala
vkodithala merged commit 940c505 into master Jul 23, 2026
38 checks passed
@vkodithala
vkodithala deleted the factory/quality-1193-open-recording-view-url branch July 23, 2026 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants