Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue#338]Tilt when dragged #2198

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JiaweiZhu28
Copy link

@JiaweiZhu28 JiaweiZhu28 commented Jul 18, 2024

Make cards and lists tilt when dragged.

Description

Describe your PR! If it fixes specific issue, mention it with "Fixes # (issue)".

Select what type of change this PR introduces:

  1. Just code/docs improvement (no functional change).
  2. Bug fix (non-breaking change which fixes an issue).
  3. New feature (non-breaking change which adds functionality).
  4. Breaking change (fix or feature that would cause existing functionality to not work as expected).

Update Waspc ChangeLog and version if needed

If you did a bug fix, new feature, or breaking change, that affects waspc, make sure you satisfy the following:

  1. I updated ChangeLog.md with description of the change this PR introduces.
  2. I bumped waspc version in waspc.cabal to reflect changes I introduced, with regards to the version of the latest wasp release, if the bump was needed.

Update example apps if needed

If you did code changes and added a new feature or modified an existing feature, make sure you satisfy the following:

  1. I updated waspc/examples/todoApp as needed (updated modified feature or added new feature) and manually checked it works correctly.
  2. I updated waspc/headless-test/examples/todoApp and its e2e tests as needed (updated modified feature and its tests or added new feature and new tests for it).

Make cards and lists tilt when dragged.
@JiaweiZhu28 JiaweiZhu28 changed the title Tilt when dragged [Issue/338]Tilt when dragged Jul 18, 2024
@JiaweiZhu28 JiaweiZhu28 changed the title [Issue/338]Tilt when dragged [Issue#338]Tilt when dragged Jul 18, 2024
Copy link
Contributor

@infomiho infomiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment. Thank you for your effort!

Could you please sync your fork with the main repo https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork so I can test it with Wasp 0.14.0.

@@ -1,18 +1,18 @@
import React, { useState, useRef, useContext } from 'react'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I ask you to revert the auto formatting in this file so the change is minimal?

Or reformat with a .prettierrc file. If you want, you can add a .prettierrc file to the root with this content:

{
  "semi": false,
  "singleQuote": true
}

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your comment, I've reverted the changes due to auto formatting.

Revert auto-fromatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants