Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2016/twitter: Add 𝕏 (fka Twitter) auth to social auth providers #2253

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dschwertfeger
Copy link

@dschwertfeger dschwertfeger commented Aug 27, 2024

Description

Adds 𝕏 auth to social auth providers. Contributes to #2016 but doesn't fix it.

Closely modeled after #2110 (and #2212)

Select what type of change this PR introduces:

  1. Just code/docs improvement (no functional change).
  2. Bug fix (non-breaking change which fixes an issue).
  3. New feature (non-breaking change which adds functionality).
  4. Breaking change (fix or feature that would cause existing functionality to not work as expected).

Update Waspc ChangeLog and version if needed

If you did a bug fix, new feature, or breaking change, that affects waspc, make sure you satisfy the following:

  1. I updated ChangeLog.md with description of the change this PR introduces.
  2. I bumped waspc version in waspc.cabal to reflect changes I introduced, with regards to the version of the latest wasp release, if the bump was needed.

Update example apps if needed

If you did code changes and added a new feature or modified an existing feature, make sure you satisfy the following:

  1. I updated waspc/examples/todoApp as needed (updated modified feature or added new feature) and manually checked it works correctly.
  2. I updated waspc/headless-test/examples/todoApp and its e2e tests as needed (updated modified feature and its tests or added new feature and new tests for it).

Note

  • 11 e2e-tests still failing (seem to be mostly about checksums?)
  • Manually tested login with 𝕏 in todoApp

@dschwertfeger
Copy link
Author

Hey @infomiho let me know if you're generally interested in this PR and I'll add what's missing and fix the rest. (docs, changelog, tests, etc.)

@infomiho
Copy link
Contributor

infomiho commented Sep 2, 2024

Hey @dschwertfeger thank you for the contribution! Sorry for the wait, I'm just getting to this today.

This is a sizeable contribution, but what I like is that you used the power of analogy to implement this :)

So what needs to happen next:

  1. Sync your fork with this repo and merge main into your branch (just to be up to date)
  2. We need to update the e2e tests (did you set up the compiler locally? if yes, then you can use the ./run helper to run ./run test:e2e:accept-all - it will rerun the e2e tests and update the checksums)
  3. I need to get this running locally and test it out (I'll need a Twitter dev app, I'm not sure if I have one, pls ping me on Discord if you can give me some credentials to test 🙏 )
  4. I'll need to review the code and you'll fix some stuff if needed
  5. Update the docs (if you haven't already)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants