Post 0.16.0 cleanup #2490
Post 0.16.0 cleanup #2490
Conversation
|
@infomiho Sorry, should have marked this one as Draft as it's still WIP. I'll ping you for another review :) |
There was a problem hiding this comment.
This got moved from SdkGenerator.Server.Operations, nothing new here.
| # apps for testing | ||
| examples/ignored |
There was a problem hiding this comment.
I sneaked this in because I like to have experimental apps in the scope of cabal run wasp-cli but I don't like them polluting my commit history.
There was a problem hiding this comment.
I just keep running cabal install when testing with apps in /tmp. Hmmm, this looks useful. I'm tempted to have a note in the waspc/README.md
| return $ left ((errorMessagePrefix ++) . indent 2) parseResult | ||
| where | ||
| errorMessagePrefix = "Failed to parse '" ++ baseTsConfigFilePath ++ "':\n" | ||
| baseTsConfigFilePath = fromRelFile (basename tsConfigFile) |
There was a problem hiding this comment.
With the indent and the new line, the message looks like this:
❌ --- [Error] Analyzing wasp project failed: -------------------------------------
1 errors found:
- Failed to parse 'tsconfig.json':
[eval]:15
"composite": true,
^^^^^^^^^^^
SyntaxError: Unexpected string
at makeContextifyScript (node:internal/vm:122:14)
at node:internal/process/execution:89:22
at [eval]-wrapper:6:24
at runScript (node:internal/process/execution:83:62)
at evalScript (node:internal/process/execution:114:10)
at node:internal/main/eval_string:30:3
Node.js v18.20.4
Without them, it looks broken:
❌ --- [Error] Analyzing wasp project failed: -------------------------------------
1 errors found:
- Failed to parse 'tsconfig.json': [eval]:15
"composite": true,
^^^^^^^^^^^
SyntaxError: Unexpected string
at makeContextifyScript (node:internal/vm:122:14)
at node:internal/process/execution:89:22
at [eval]-wrapper:6:24
at runScript (node:internal/process/execution:83:62)
at evalScript (node:internal/process/execution:114:10)
at node:internal/main/eval_string:30:3
Node.js v18.20.4
| # apps for testing | ||
| examples/ignored |
There was a problem hiding this comment.
I just keep running cabal install when testing with apps in /tmp. Hmmm, this looks useful. I'm tempted to have a note in the waspc/README.md
| @@ -73,21 +73,21 @@ validateFieldValue fullyQualifiedFieldName expectedValue actualValue = | |||
| unwords | |||
| [ "Invalid value for the", | |||
| "\"" ++ show fullyQualifiedFieldName ++ "\"", | |||
| "field in tsconfig.json, you must set it to:", | |||
There was a problem hiding this comment.
I dislike this change because it might not be clear to user which file exactly to change if there are multiple TS config files. Can we keep the file name and display the correct one for both Wasp lang and TS based config?
| extOperationImportToImportJson = | ||
| GJI.jsImportToImportJson | ||
| . Just | ||
| . applyExtImportAlias |
There was a problem hiding this comment.
Do we need to apply the _ext suffix here if the extImportToJsImport function adds it as well?
No description provided.