Adds option to supply a dict or yaml file to loop directyl#25
Open
avdudchenko wants to merge 8 commits into
Open
Adds option to supply a dict or yaml file to loop directyl#25avdudchenko wants to merge 8 commits into
avdudchenko wants to merge 8 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
==========================================
+ Coverage 94.36% 94.39% +0.03%
==========================================
Files 38 38
Lines 3726 3748 +22
==========================================
+ Hits 3516 3538 +22
Misses 210 210 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
adam-a-a
reviewed
Oct 21, 2025
adam-a-a
reviewed
Oct 21, 2025
adam-a-a
reviewed
Oct 21, 2025
Comment on lines
+314
to
+319
| print( | ||
| "val", | ||
| sweep_directory[loop_value]["simulation_setup"][ | ||
| "build_defaults" | ||
| ], | ||
| ) |
adam-a-a
reviewed
Oct 21, 2025
adam-a-a
previously approved these changes
Oct 21, 2025
Contributor
adam-a-a
left a comment
adam-a-a
left a comment
There was a problem hiding this comment.
LGTM - only a couple of cleanup comments
Co-authored-by: Adam Atia <aatia@keylogic.com>
k1nshuk
previously approved these changes
Nov 23, 2025
This reverts commit 4f21fe8.
Contributor
|
@avdudchenko is this needed for a "Feb" release? |
ksbeattie
added
Priority:Low
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes it possible to supply a dict instead of a yaml file for configuring loop tool directly a small change.