Add resumable model download with retry, timeout, and offline mode#77
Open
janhilgard wants to merge 1 commit intowaybarrios:mainfrom
Open
Add resumable model download with retry, timeout, and offline mode#77janhilgard wants to merge 1 commit intowaybarrios:mainfrom
janhilgard wants to merge 1 commit intowaybarrios:mainfrom
Conversation
Owner
|
@janhilgard |
47e726b to
5b9db2b
Compare
Collaborator
Author
|
You're right, sorry about that! I've squashed everything into a single clean commit now. |
5b9db2b to
ee5d6be
Compare
Large model downloads via huggingface_hub often hang or fail around 10GB. This adds a pre-download step with configurable retry/timeout before load_model() is called, so interrupted downloads can be resumed. New CLI flags for `serve`: --download-timeout, --download-retries, --offline New subcommand: `vllm-mlx download <model>` for pre-warming caches Closes waybarrios#75 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
8e75792 to
a510953
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
load_model()is called, so interrupted downloads of large models can be resumedserve:--download-timeout,--download-retries,--offlinevllm-mlx download <model>for pre-warming HF caches (useful for CI/CD)snapshot_download()call in tokenizer fallback path with the new retry-aware wrapperMotivation
Addresses #75 — HuggingFace downloads hang or fail around 10GB for large models with no way to resume.
Usage
Test plan
pytest tests/test_download.py -v)vllm-mlx download mlx-community/Qwen3-0.6B-4bitsucceedsruff checkandblackpass on all changed files🤖 Generated with Claude Code