fix: Coerce tool call arguments to match schema types#95
Open
janhilgard wants to merge 1 commit intowaybarrios:mainfrom
Open
fix: Coerce tool call arguments to match schema types#95janhilgard wants to merge 1 commit intowaybarrios:mainfrom
janhilgard wants to merge 1 commit intowaybarrios:mainfrom
Conversation
Add _coerce_tool_arguments() that auto-stringifies object/array values when the tool schema expects a string. Fixes a common LLM failure mode where models output raw JSON objects instead of JSON strings (e.g. when writing package.json, the model puts content as an object instead of a string). Applied to all 4 tool call emission paths (non-streaming, streaming with reasoning, streaming without reasoning, streaming fallback). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_coerce_tool_arguments()that auto-stringifies object/array values when the tool schema expects a stringpackage.json, the model putscontentas an object instead of a string)Problem
When using tool calling with coding assistants (e.g. OpenCoder), models sometimes generate:
{"file_path": "package.json", "content": {"name": "app", "version": "1.0.0"}}instead of:
{"file_path": "package.json", "content": "{\"name\": \"app\", \"version\": \"1.0.0\"}"}The client validates against the tool schema (
content: string) and fails with:expected string, received objectFix
Server-side coercion: after parsing tool call arguments, check each field against the tool schema. If schema says
type: "string"but the value is an object/array,json.dumps()it automatically.Test plan
🤖 Generated with Claude Code