Remove sudo from makefile and add .out docs to make clean target#331
Open
jastintime wants to merge 2 commits into
Open
Remove sudo from makefile and add .out docs to make clean target#331jastintime wants to merge 2 commits into
jastintime wants to merge 2 commits into
Conversation
README.md already tells users to run the install target with sudo i.e `sudo make install`, removing it from the makefile removes a dependency on sudo and makes the install target work on machines without sudo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR removes an unnecessary usage of
sudofrom the install target,make installwill fail without superuser(chown will fail) permissions and must be ran{sudo,doas} make installmaking this usage redundant. This usage caused the program to fail on machines withoutsudo.I also added
docs/*.outto the makecleantarget, this is in line withmake cleanclearing docs/*.gz.