-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] set png compression/filter type through arguments #27
base: main
Are you sure you want to change the base?
Conversation
Pr looks great! Is there anyway we can make this generic enough for all the backend formats ? |
Compression type and filter type are options only available for png format. We can add options for other formats by using a similar smart pointer |
Ok I see, in that case, can we offload the compression to some other crate to do it for us which can support multiple formats? If that's too big of a task right now, then it's just best to merge this for now :D Also while we're on the topic, I added man-page generation in build.rs with scdoc, would you mind documenting this flag in the 1 and 7 sections of wayshot? |
ab72115
to
a0c8e39
Compare
4b1fc91
to
43fae61
Compare
This is a really good PR and I wish to get this to production someday. I just need to find a good way to compress all supported formats. |
Implemented the ability to set png compression/filter type with
-C
and-F
argument