Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

20231029 clippy improvements #74

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

20231029 clippy improvements #74

wants to merge 2 commits into from

Conversation

uncomfyhalomacro
Copy link

Open for discussion. I haven't done real code edit yet to apply clippy suggestions as some parts of the code seems unlikely to have it applied.

CC: @AndreasBackx @Shinyzenith

@Shinyzenith
Copy link
Member

Is there any way to enable lints globally and ignore particular lines or files selectively?

@uncomfyhalomacro
Copy link
Author

Is there any way to enable lints globally and ignore particular lines or files selectively?

I remember it's still an RFC 😭 but idk. The clippy.toml configuration option is still limited

@Shinyzenith
Copy link
Member

If that's the case, it's a nack from me. Keeping them in sync will be a mess if things change and the general copy paste nature of this feels wasteful.

If the situation of the rfc changes then I can consider this.

If any other maintainer including Andreas would like to see this merged, feel free to drop an ack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uncomfyhalomacro @Shinyzenith