fix:On update failure, clear zoneID and recordIDs.

we11adam · Jul 15, 2024 · ff66c67 · ff66c67
1 parent f524e73
commit ff66c67
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/updater/cloudflare/cloudflare.go b/updater/cloudflare/cloudflare.go
@@ -123,6 +123,7 @@ func (c *Cloudflare) updateDNSRecord(ctx context.Context, recordType, ip string)
 		_, err := c.client.UpdateDNSRecord(ctx, cloudflare.ZoneIdentifier(c.zoneID), updateParams)
 		if err != nil {
 			slog.Error("[CloudFlare] failed to update DNS record:", "error", err, "type", recordType)
+			delete(c.recordIDs, recordType)
 			return err
 		}
 		slog.Info("[CloudFlare] DNS record updated successfully", "type", recordType, "ip", ip)
@@ -133,6 +134,7 @@ func (c *Cloudflare) updateDNSRecord(ctx context.Context, recordType, ip string)
 	dnsRecords, _, err := c.client.ListDNSRecords(ctx, cloudflare.ZoneIdentifier(c.zoneID), params)
 	if err != nil {
 		slog.Error("[CloudFlare] failed to list DNS records:", "error", err, "type", recordType)
+		c.zoneID = ""
 		return err
 	}
 
@@ -151,6 +153,7 @@ func (c *Cloudflare) updateDNSRecord(ctx context.Context, recordType, ip string)
 		_, err := c.client.UpdateDNSRecord(ctx, cloudflare.ZoneIdentifier(c.zoneID), updateParams)
 		if err != nil {
 			slog.Error("[CloudFlare] failed to update DNS record:", "error", err, "type", recordType)
+			delete(c.recordIDs, recordType)
 			return err
 		}
 		slog.Info("[CloudFlare] DNS record updated successfully", "type", recordType, "ip", ip)