Add string for gridpoints and fix ISO interval#798
Closed
JoshStern wants to merge 1 commit intoweather-gov:masterfrom
Closed
Add string for gridpoints and fix ISO interval#798JoshStern wants to merge 1 commit intoweather-gov:masterfrom
JoshStern wants to merge 1 commit intoweather-gov:masterfrom
Conversation
- The gridpoint endpoint returns gridX and gridY as strings while other endpoints return them as integers. This updates the openapi definition to support that (and will fix generated clients). - The ISO8601 schema definition uses oneOf when a valid timestamp may satisfy multiple of the regexs provided. This updates to the anyOf keyword which better matches the desired behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related discussion: #768.