Skip to content

chore: sync typescript-go submodule to 6a088fbd7#968

Merged
fansenze merged 1 commit into
mainfrom
chore/sync-typescript-go-20260518
May 18, 2026
Merged

chore: sync typescript-go submodule to 6a088fbd7#968
fansenze merged 1 commit into
mainfrom
chore/sync-typescript-go-20260518

Conversation

@fansenze

Copy link
Copy Markdown
Contributor

Summary

Sync typescript-go submodule from c282336ea to 6a088fbd7 (24 commits, 2026-05-14 → 2026-05-17). Mostly panic / bug fixes from upstream, plus a few additive items.

  • New shim re-exports (additive): checker.GetPropertyNameFromType, checker.GetSetAccessorValueParameter, checker.IsTypeUsableAsPropertyName, ls.FixClassIncorrectlyImplementsInterfaceProvider, project.UpdateReasonDidCloseFile, signature-help classification types in lsp/lsproto.
  • Signature change in tsoptions.ParseExtendedConfig (resolutionStack is now []tspath.Path instead of []string). No callers in rslint, so no adaptation needed.
  • internal/lsp/server.go (forked from upstream) has no relevant upstream drift in this window. session.DidCloseFile behavior change (Update snapshot and projects on file close microsoft/typescript-go#3837) is transparent to rslint's existing handleDidClose.

Notable upstream commits in range: implement-interface quick fix (#3499), signature help tooltip coloring for VS (#3821), update snapshot and projects on file close (#3837), plus assorted panic fixes.

Test plan

  • CI green (build / tests / lint)

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the github.com/microsoft/typescript-go dependency and subproject commit across the repository. Key changes include the addition of several new shim functions and constants in the checker, ls, lsproto, and project packages, as well as a signature update for ParseExtendedConfig in shim/tsoptions/shim.go to use tspath.Path for the resolution stack. There are no review comments provided for this pull request, and I have no feedback to provide.

@fansenze fansenze merged commit a74373d into main May 18, 2026
13 checks passed
@fansenze fansenze deleted the chore/sync-typescript-go-20260518 branch May 18, 2026 05:26
eryue0220 added a commit to eryue0220/rslint that referenced this pull request May 19, 2026
… into feat/jest-expect-expect

* 'feat/jest-expect-expect' of github.com:eryue0220/rslint: (22 commits)
  chore: sync typescript-go submodule to 6a088fbd7 (web-infra-dev#968)
  chore(deps): update tailwindcss monorepo to ^4.3.0 (web-infra-dev#967)
  fix: handle exhaustive-deps shorthand references (web-infra-dev#963)
  feat: port rule @typescript-eslint/no-unnecessary-type-conversion (web-infra-dev#960)
  feat: port rule @typescript-eslint/no-unnecessary-parameter-property-assignment (web-infra-dev#958)
  feat: port rule @typescript-eslint/no-unnecessary-qualifier (web-infra-dev#959)
  feat: port rule @typescript-eslint/no-invalid-this (web-infra-dev#957)
  feat: port rule @typescript-eslint/no-import-type-side-effects (web-infra-dev#956)
  feat: port rule @typescript-eslint/init-declarations (web-infra-dev#955)
  feat: port rule @typescript-eslint/no-confusing-non-null-assertion (web-infra-dev#954)
  feat: port rule @typescript-eslint/explicit-module-boundary-types (web-infra-dev#953)
  feat: port rule @typescript-eslint/class-methods-use-this (web-infra-dev#952)
  feat: port rule @typescript-eslint/no-wrapper-object-types (web-infra-dev#951)
  feat: port rule @typescript-eslint/no-unsafe-declaration-merging (web-infra-dev#949)
  feat: port rule @typescript-eslint/no-empty-object-type (web-infra-dev#946)
  feat: port rule no-unsafe-function-type (web-infra-dev#947)
  ci: disable Swatinem/rust-cache cache-bin to fix flaky macos rust jobs (web-infra-dev#945)
  feat: port rule jsx-a11y/prefer-tag-over-role (web-infra-dev#942)
  feat: port rule jsx-a11y/no-aria-hidden-on-focusable (web-infra-dev#943)
  chore: sync typescript-go submodule to c282336ea (web-infra-dev#944)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant