Skip to content

Conversation

hardfist
Copy link
Contributor

@hardfist hardfist commented May 31, 2025

Summary

update rust version to support sftrace, related to rust-lang/rust#140790

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label May 31, 2025
Copy link

netlify bot commented May 31, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit e636e01
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/683bbe4388406e000842f38a

Copy link

codspeed-hq bot commented May 31, 2025

CodSpeed Performance Report

Merging #10539 will not alter performance

Comparing yj/update-rust-version (e636e01) with main (89f8ece)

🎉 Hooray! codspeed-node just leveled up to 4.0.1!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 12 untouched benchmarks

@hardfist hardfist enabled auto-merge (squash) June 1, 2025 03:39
@hardfist hardfist requested a review from chenjiahan June 1, 2025 03:39
@chenjiahan chenjiahan requested a review from Copilot June 1, 2025 11:57
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Rust channel to support sftrace by converting several formatting expressions to the new Rust string interpolation syntax. The changes aim to modernize the code with new formatting patterns across multiple crates while preserving the original behavior.

Reviewed Changes

Copilot reviewed 104 out of 104 changed files in this pull request and generated no comments.

Show a summary per file
File Description
crates/rspack_plugin_banner/src/lib.rs Updated block comment formatting to use new interpolation.
crates/rspack_napi_macros/src/tagged_union.rs Changed union type and intermediate identifier string formatting.
crates/rspack_macros/src/plugin.rs Updated formatting of the inner plugin identifier.
crates/rspack_macros/src/cacheable_dyn.rs Modified archived target identifier creation to the new format.
crates/rspack_loader_lightningcss/src/config.rs Adjusted error message formatting for browserslist parsing.
crates/rspack_ids/src/id_helpers.rs Updated panic message formatting when a module isn’t found.
crates/rspack_error/src/graphical.rs Revised formatting for diagnostic code and source location messages.
crates/rspack_core/src/resolver/mod.rs Replaced manual unwrapping with pattern matching using new syntax.
crates/rspack_core/src/exports/utils.rs Updated export usage condition formatting for clarity.
crates/rspack_cacheable/src/serialize.rs Simplified Display implementation using new syntax.
crates/rspack_cacheable/src/deserialize.rs Simplified Display implementation using new syntax.
crates/node_binding/src/swc.rs Updated error formatting in both transform and minify functions.
crates/node_binding/src/resolver_factory.rs Modified resolver type error message with new string interpolation.
crates/node_binding/src/resolver.rs Adjusted error handling formatting in resolver functions.
crates/node_binding/src/raw_options/raw_module/mod.rs Updated Debug formatting of RawRuleSetCondition variants.
crates/node_binding/src/raw_options/raw_builtins/raw_lightning_css_minimizer.rs Updated browserslist error formatting.
crates/node_binding/src/raw_options/raw_builtins/raw_lazy_compilation.rs Simplified regex error message formatting.
crates/node_binding/src/panic.rs Modernized panic log formatting for debug info.
crates/node_binding/src/lib.rs Updated thread name creation to use new interpolation.
crates/node_binding/src/dependencies/entry_dependency.rs Revised error message formatting for duplicate dependency resolution.

Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hardfist hardfist merged commit 0e36d5b into main Jun 1, 2025
35 checks passed
@hardfist hardfist deleted the yj/update-rust-version branch June 1, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants