-
-
Notifications
You must be signed in to change notification settings - Fork 775
chore: update rust channel to support sftrace #10539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for rspack canceled.
|
CodSpeed Performance ReportMerging #10539 will not alter performanceComparing 🎉 Hooray!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Rust channel to support sftrace by converting several formatting expressions to the new Rust string interpolation syntax. The changes aim to modernize the code with new formatting patterns across multiple crates while preserving the original behavior.
Reviewed Changes
Copilot reviewed 104 out of 104 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
crates/rspack_plugin_banner/src/lib.rs | Updated block comment formatting to use new interpolation. |
crates/rspack_napi_macros/src/tagged_union.rs | Changed union type and intermediate identifier string formatting. |
crates/rspack_macros/src/plugin.rs | Updated formatting of the inner plugin identifier. |
crates/rspack_macros/src/cacheable_dyn.rs | Modified archived target identifier creation to the new format. |
crates/rspack_loader_lightningcss/src/config.rs | Adjusted error message formatting for browserslist parsing. |
crates/rspack_ids/src/id_helpers.rs | Updated panic message formatting when a module isn’t found. |
crates/rspack_error/src/graphical.rs | Revised formatting for diagnostic code and source location messages. |
crates/rspack_core/src/resolver/mod.rs | Replaced manual unwrapping with pattern matching using new syntax. |
crates/rspack_core/src/exports/utils.rs | Updated export usage condition formatting for clarity. |
crates/rspack_cacheable/src/serialize.rs | Simplified Display implementation using new syntax. |
crates/rspack_cacheable/src/deserialize.rs | Simplified Display implementation using new syntax. |
crates/node_binding/src/swc.rs | Updated error formatting in both transform and minify functions. |
crates/node_binding/src/resolver_factory.rs | Modified resolver type error message with new string interpolation. |
crates/node_binding/src/resolver.rs | Adjusted error handling formatting in resolver functions. |
crates/node_binding/src/raw_options/raw_module/mod.rs | Updated Debug formatting of RawRuleSetCondition variants. |
crates/node_binding/src/raw_options/raw_builtins/raw_lightning_css_minimizer.rs | Updated browserslist error formatting. |
crates/node_binding/src/raw_options/raw_builtins/raw_lazy_compilation.rs | Simplified regex error message formatting. |
crates/node_binding/src/panic.rs | Modernized panic log formatting for debug info. |
crates/node_binding/src/lib.rs | Updated thread name creation to use new interpolation. |
crates/node_binding/src/dependencies/entry_dependency.rs | Revised error message formatting for duplicate dependency resolution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
update rust version to support sftrace, related to rust-lang/rust#140790
Checklist