fix(cache): invalidate persistent cache when build dependencies snapshot is missing - #14944
Open
lazerg wants to merge 1 commit into
Open
fix(cache): invalidate persistent cache when build dependencies snapshot is missing#14944lazerg wants to merge 1 commit into
lazerg wants to merge 1 commit into
Conversation
lazerg
force-pushed
the
fix/issue-14864-snapshot-build-recovery
branch
from
July 25, 2026 16:38
a803422 to
0a73997
Compare
lazerg
force-pushed
the
fix/issue-14864-snapshot-build-recovery
branch
from
July 25, 2026 16:39
0a73997 to
493c45c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Persistent-cache recovery trusted the
snapshot_buildscope even when it was empty.BuildDeps::validateonly returnedInvalidwhen a tracked file was modified or removed, so an absent build-dependency snapshot fell through toValid { tracked_files: 0 }. Recovery then reused the cached artifacts and kept the old output, ignoring a file listed incache.buildDependenciesthat had changed.validatenow also invalidates when the BUILD scope has no records while build dependencies were configured and the rest of the cache is still present, which only happens when that snapshot was lost. A genuine first build (no cache at all) stays valid.Related links
Fixes #14864
Checklist