fix(cache): recover from corrupt persistent cache module graph - #14945
Open
lazerg wants to merge 1 commit into
Open
fix(cache): recover from corrupt persistent cache module graph#14945lazerg wants to merge 1 commit into
lazerg wants to merge 1 commit into
Conversation
lazerg
force-pushed
the
fix/issue-14858-persistent-cache-recovery
branch
from
July 25, 2026 17:21
13b5dea to
cb82d67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A corrupt module graph entry in the persistent cache made recovery call
.expect()on the decode result, which aborted the whole process. It now returns the decode error instead, soload_occasionresets the make scope and the next build recomputes it, the same way snapshot and build-dependency load failures are already handled.The devtool and minimize occasions can skip a bad entry, but this one can't: dropping a single node would leave the module graph inconsistent, so the whole scope is reset.
Related links
Closes #14858
Checklist