fix(cache): recover from corrupt persistent cache meta instead of panicking - #14946
Open
lazerg wants to merge 1 commit into
Open
fix(cache): recover from corrupt persistent cache meta instead of panicking#14946lazerg wants to merge 1 commit into
lazerg wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Recovering the persistent cache
metascope decoded its stored value with.expect("should decode success"), so a corrupted entry aborted the whole process instead of being handled as a recoverable failure. Propagate the decode error instead.CacheContext::load_occasionalready treats a failed recovery by resetting the occasion's scope, so a badmetaentry now falls back to a clean rebuild rather than a panic.Related links
Fixes #14859
Checklist