fix: keep incremental missing-module diagnostic location stable - #14947
Open
lazerg wants to merge 1 commit into
Open
fix: keep incremental missing-module diagnostic location stable#14947lazerg wants to merge 1 commit into
lazerg wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a module imports the same missing request more than once, an incremental rebuild could report the "Module not found" error at a different import than a cold build. The incremental repair path groups the affected dependencies straight from a
HashSet, so the dependency that supplies the diagnostic location was picked in arbitrary order. Sort each group back into the parent module's source order before factorizing, so the reported location stays the same whether the graph was repaired incrementally or built cold.Related links
Closes #14857
Checklist