fix!: exclude patterns should be merged with rstest default value
#523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the behavior of exclude patterns in the rstest configuration to merge custom exclude patterns with the default patterns instead of overriding them completely.
- Moved the temporary rstest output directory glob to the default exclude patterns
- Removed the manual concatenation logic that was overriding the default patterns
- Updated documentation to clarify that custom exclude patterns are merged with defaults
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/config.ts | Fixed exclude pattern merging logic by moving temp dir pattern to defaults and removing override behavior |
| e2e/rstest.config.ts | Simplified exclude configuration to only include fixture patterns, relying on default patterns for common exclusions |
| e2e/exclude/index.test.ts | Added comprehensive tests to verify default exclude patterns work with and without custom excludes |
| e2e/exclude/fixtures/index.test.ts | Added test fixture file for exclude pattern testing |
| e2e/scripts/index.ts | Added expectExecFailed helper function for testing failure scenarios |
| website/docs/en/config/test/exclude.mdx | Updated English documentation to clarify merge behavior |
| website/docs/zh/config/test/exclude.mdx | Updated Chinese documentation to clarify merge behavior |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
excludepatterns should be merged with rstest default value.Related Links
Checklist