Skip to content

[WebDriver: Set Window Rect] Make best-effort with partial input according to latest spec #53421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
whimboo merged 6 commits into from
Jul 11, 2025
Merged

[WebDriver: Set Window Rect] Make best-effort with partial input according to latest spec #53421

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7b43ee9
Make best-effort change with partial input according to latest spec
yezhizhen Jun 26, 2025
49d94ba
Fix Lint
yezhizhen Jun 26, 2025
29037dd
Apply Henrik's suggestion
yezhizhen Jul 3, 2025
3de4b37
Revert to initial solution to check more
yezhizhen Jul 9, 2025
f22c15c
Update all Wayland comment
yezhizhen Jul 9, 2025
02965b7
Wayland position should stay still
yezhizhen Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 26 additions & 9 deletions webdriver/tests/classic/set_window_rect/set.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,15 +143,15 @@ def test_x_y_floats(session):
response = set_window_rect(session, {"x": 150.5, "y": 250})
value = assert_success(response)

# Wayland doesn't return correct coordinates after changing window position.
# Unlike X11, Wayland does not permit applications to change their window position programmatically.
if not is_wayland():
assert value["x"] == 150
assert value["y"] == 250

response = set_window_rect(session, {"x": 150, "y": 250.5})
value = assert_success(response, session.window.rect)

# Wayland doesn't return correct coordinates after changing window position.
# Unlike X11, Wayland does not permit applications to change their window position programmatically.
if not is_wayland():
assert value["x"] == 150
assert value["y"] == 250
Expand Down Expand Up @@ -186,7 +186,14 @@ def test_width_height_floats(session):
{"height": None, "Y": None},

{"width": None, "height": None, "x": None, "y": None},
])
def test_with_none_values(session, rect):
original = session.window.rect
response = set_window_rect(session, rect)
assert_success(response, original)


@pytest.mark.parametrize("rect", [
{"width": 200},
{"height": 200},
{"x": 200},
Expand All @@ -196,10 +203,20 @@ def test_width_height_floats(session):
{"width": 200, "y": 200},
{"height": 200, "y": 200},
])
def test_no_change(session, rect):
def test_partial_input(session, rect):
original = session.window.rect
response = set_window_rect(session, rect)
assert_success(response, original)
value = assert_success(response, session.window.rect)

assert value["width"] == rect.get("width", original["width"])
assert value["height"] == rect.get("height", original["height"])
# Unlike X11, Wayland does not permit applications to change their window position programmatically.
if not is_wayland():
assert value["x"] == rect.get("x", original["x"])
assert value["y"] == rect.get("y", original["y"])
Copy link
Contributor

@whimboo whimboo Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sadym-chromium i assume that we run Chrome by default with XWAYLAND so that it can still set the position of the window? So we probably should keep what we have here and not explicitely check the x and y coordinates which can be different between browsers.

else:
value["x"] == original["x"]
value["y"] == original["y"]


def test_set_to_available_size(
Expand All @@ -217,7 +234,7 @@ def test_set_to_available_size(
response = set_window_rect(session, target_rect)
value = assert_success(response, session.window.rect)

# Wayland doesn't return correct coordinates after changing window position.
# Unlike X11, Wayland does not permit applications to change their window position programmatically.
if not is_wayland():
assert value == target_rect
else:
Expand Down Expand Up @@ -337,7 +354,7 @@ def test_x_y(session):
assert value["width"] == original["width"]
assert value["height"] == original["height"]

# Wayland doesn't return correct coordinates after changing window position.
# Unlike X11, Wayland does not permit applications to change their window position programmatically.
if not is_wayland():
assert value["x"] == original["x"] + 10
assert value["y"] == original["y"] + 10
Expand Down Expand Up @@ -371,7 +388,7 @@ def test_x_as_current(session):
assert value["width"] == original["width"]
assert value["height"] == original["height"]

# Wayland doesn't return correct coordinates after changing window position.
# Unlike X11, Wayland does not permit applications to change their window position programmatically.
if not is_wayland():
assert value["x"] == original["x"]
assert value["y"] == original["y"] + 10
Expand All @@ -388,7 +405,7 @@ def test_y_as_current(session):

assert value["width"] == original["width"]
assert value["height"] == original["height"]
# Wayland doesn't return correct coordinates after changing window position.
# Unlike X11, Wayland does not permit applications to change their window position programmatically.
if not is_wayland():
assert value["x"] == original["x"] + 10
assert value["y"] == original["y"]
Expand All @@ -406,7 +423,7 @@ def test_negative_x_y(session, minimal_screen_position):
assert value["width"] == original["width"]
assert value["height"] == original["height"]

# Wayland doesn't return correct coordinates after changing window position.
# Unlike X11, Wayland does not permit applications to change their window position programmatically.
if not is_wayland():
assert value["x"] <= minimal_screen_position[0]
assert value["y"] <= minimal_screen_position[1]
Expand Down