Skip to content

webdriver: Report error instead of panic for invalid WebElement&ShadowRoot reference #55527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
servo-wpt-sync merged 1 commit into from
Oct 18, 2025
Merged

webdriver: Report error instead of panic for invalid WebElement&ShadowRoot reference #55527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions webdriver/tests/classic/execute_async_script/arguments.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,9 +162,9 @@ def test_stale_element_reference(session, stale_element, as_frame):
assert_error(result, "stale element reference")


@pytest.mark.parametrize("type", [WebFrame, WebWindow], ids=["frame", "window"])
@pytest.mark.parametrize("type", [WebFrame, WebWindow, WebElement, ShadowRoot], ids=["frame", "window", "element", "shadow_root"])
@pytest.mark.parametrize("value", [None, False, 42, [], {}])
def test_invalid_argument_for_window_with_invalid_type(session, type, value):
def test_invalid_argument_for_reference_with_invalid_type(session, type, value):
reference = type(session, value)

result = execute_async_script(session, "arguments[1](true)", args=(reference,))
Expand Down
4 changes: 2 additions & 2 deletions webdriver/tests/classic/execute_script/arguments.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,9 +150,9 @@ def test_stale_element_reference(session, stale_element, as_frame):
assert_error(result, "stale element reference")


@pytest.mark.parametrize("type", [WebFrame, WebWindow], ids=["frame", "window"])
@pytest.mark.parametrize("type", [WebFrame, WebWindow, WebElement, ShadowRoot], ids=["frame", "window", "element", "shadow_root"])
@pytest.mark.parametrize("value", [None, False, 42, [], {}])
def test_invalid_argument_for_window_with_invalid_type(session, type, value):
def test_invalid_argument_for_reference_with_invalid_type(session, type, value):
reference = type(session, value)

result = execute_script(session, "return true", args=(reference,))
Expand Down