-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Add variants to exclude event timing targetSelector from Interop 2025 #57039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add variants to exclude event timing targetSelector from Interop 2025 #57039
Conversation
|
cc @nt1m |
|
@canova I don't think that worked unfortunately, see the Firefox/Safari results at: https://github.com/web-platform-tests/wpt/pull/57039/checks?check_run_id=59674427618 I think the wildcard needs to be adjusted/removed, though I'm not sure how exactly. |
|
Oh welp, I just saw it. Lemme try some more things (I have to try in this PR, sorry about the pings in advance). |
4f0e96d to
ac51ae7
Compare
|
I'll hold back the LGTM given that you are iterating, but I very much appreciate that you are helping get this resolved! |
ac51ae7 to
00eb10e
Compare
|
Okay, after seeing both I guess we have a few options:
I would personally prefer option 2. I don't really like option 1 because it might be disruptive for the existing tests and I would prefer to keep the side-effects as minimal as possible. I'm happy to write a script that's similar to |
|
I'd accept any solution. (1) seems least overhead/surprise long term TBH and just needs an audit that the changes don't do anything unexpected. I guess I defer the choices between (1) and (2) to others who understand the infra. (I have no other suggestions for (3)). As a last resort, what would (4) entail? Perhaps removing the idlharness from interop 2025 list or removing the IDL definition in the spec for a short while? Perhaps manually changing the idlharness test or just accepting that it looks like a fail in the dashboards? |
|
Maybe @jgraham, @gsnedders or @foolip have thoughts here |
This is related to: web-platform-tests/interop#1233
Corresponding WPT metadata change: web-platform-tests/wpt-metadata#8377