Skip to content

Conversation

@canova
Copy link
Member

@canova canova commented Jan 7, 2026

This is related to: web-platform-tests/interop#1233
Corresponding WPT metadata change: web-platform-tests/wpt-metadata#8377

@canova
Copy link
Member Author

canova commented Jan 7, 2026

cc @nt1m

@nt1m
Copy link
Member

nt1m commented Jan 7, 2026

@canova I don't think that worked unfortunately, see the Firefox/Safari results at: https://github.com/web-platform-tests/wpt/pull/57039/checks?check_run_id=59674427618

I think the wildcard needs to be adjusted/removed, though I'm not sure how exactly.

@canova
Copy link
Member Author

canova commented Jan 7, 2026

Oh welp, I just saw it. Lemme try some more things (I have to try in this PR, sorry about the pings in advance).

@canova canova force-pushed the eventtiming-targetselector branch 2 times, most recently from 4f0e96d to ac51ae7 Compare January 7, 2026 17:59
@mmocny
Copy link
Contributor

mmocny commented Jan 7, 2026

I'll hold back the LGTM given that you are iterating, but I very much appreciate that you are helping get this resolved!

@canova canova force-pushed the eventtiming-targetselector branch from ac51ae7 to 00eb10e Compare January 8, 2026 09:56
@canova
Copy link
Member Author

canova commented Jan 8, 2026

Okay, after seeing both ?exclude=targetSelector and ?exclude=.*targetSelector.* didn't work, I was a suspicious and decided to do some local debugging. And found out that I was missing a script import for /common/subset-tests-by-key.js. Apparently this is the whole script that does the filtering. But even adding that didn't work, because apparently /common/subset-tests-by-key.js script only matches for the tests by their "key" and not the full test name string. So, for these tests, the keys are always PerformanceEventTiming, that's why we can't actually filter by targetSelector no matter what we put in the filter.

I guess we have a few options:

  1. Update the /common/subset-tests-by-key.js script to also look at the full test string.
  2. Add another script called subset-tests-by-name.js to match the test names.
  3. ?? (I couldn't find another existing script in the repo, but there might be some solution that I couldn't see)
  4. Just accept that it's not possible (without a lot of changes) and move on.

I would personally prefer option 2. I don't really like option 1 because it might be disruptive for the existing tests and I would prefer to keep the side-effects as minimal as possible. I'm happy to write a script that's similar to subset-tests-by-key.js that matches for the full test strings. But that's going to be a lot more changes. So I wanted to make sure you're also onboard with this.

cc @nt1m @mmocny

@mmocny
Copy link
Contributor

mmocny commented Jan 8, 2026

I'd accept any solution. (1) seems least overhead/surprise long term TBH and just needs an audit that the changes don't do anything unexpected. I guess I defer the choices between (1) and (2) to others who understand the infra.

(I have no other suggestions for (3)).


As a last resort, what would (4) entail? Perhaps removing the idlharness from interop 2025 list or removing the IDL definition in the spec for a short while? Perhaps manually changing the idlharness test or just accepting that it looks like a fail in the dashboards?

@nt1m
Copy link
Member

nt1m commented Jan 8, 2026

Maybe @jgraham, @gsnedders or @foolip have thoughts here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants