[Masonry] Handle inline size containment #57085
Draft
+903
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle inline size containment by using the author-specified inline size and ignoring children when computing min-max-content sizes. This also accounts for the case where `contain: size` is used, but no inline/block size is specified (test 015 covers this). Doesn't implement block-size containment; tests failing as a result of this were added to the TestExpectations file. This references the Grid CSS change to handle inline size containment: https://chromium-review.googlesource.com/c/chromium/src/+/2935766 and creates Grid-Lanes specific versions of the tests used to test this property in CSS Grid. Bug: 343257585 Change-Id: I405a733a78c971bb276c398cc43a97576c4e12e3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle inline size containment by using the author-specified inline size
and ignoring children when computing min-max-content sizes. This also
accounts for the case where
contain: sizeis used, but no inline/blocksize is specified (test 015 covers this).
Doesn't implement block-size containment; tests failing as a result of
this were added to the TestExpectations file.
This references the Grid CSS change to handle inline size containment:
https://chromium-review.googlesource.com/c/chromium/src/+/2935766 and
creates Grid-Lanes specific versions of the tests used to test this
property in CSS Grid.
Bug: 343257585
Change-Id: I405a733a78c971bb276c398cc43a97576c4e12e3
Reviewed-on: https://chromium-review.googlesource.com/7337635
WPT-Export-Revision: 3b6ede22176e08b40975fd9e72c6b535d5483c43