Skip to content

merge_pr_49065

Compare
Choose a tag to compare
@github-actions github-actions released this 08 Nov 20:48

Change Observer: Fix flaky test caused by cleanup code

The cleanup code for directory_tests may fail when it attempts to
remove a a entry that no longer exists. This changes it to ignore when
it fails to remove an entry since it doesn't matter as long as it
doesn't exist anymore.

This may be due to a race issue where cleanup code from a previous test
hadn't finished deleting all its entries when directory_test takes a
snapshot of them. But it does before directory_test can remove the
entry.

Fixed: 377480361
Change-Id: I5c173ba6afae5ddf7db0a4d8d154319dd5f0fb85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6001305
Reviewed-by: Daseul Lee [email protected]
Commit-Queue: Nathan Memmott [email protected]
Cr-Commit-Position: refs/heads/main@{#1380545}