-
-
Notifications
You must be signed in to change notification settings - Fork 57
Version Packages #999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Version Packages #999
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6a77563
chore: release [skip ci]
wdio-bot e9f9130
Update packages/image-comparison-core/CHANGELOG.md
wswebcreation fefe21e
Update packages/image-comparison-core/CHANGELOG.md
wswebcreation ddd7abe
Update packages/image-comparison-core/CHANGELOG.md
wswebcreation fd33a84
Update CHANGELOG.md
wswebcreation 8cd48af
Update CHANGELOG.md
wswebcreation 0aa2bda
Update CHANGELOG.md
wswebcreation File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| # @wdio/image-comparison-core | ||
|
|
||
| ## 1.0.0 | ||
|
|
||
| ### Major Changes | ||
|
|
||
| - 1326e99: ## π₯ Major Release: New @wdio/image-comparison-core Package | ||
|
|
||
| ### ποΈ Architectural Refactor | ||
|
|
||
| This release introduces a **completely new core architecture** with the dedicated `@wdio/image-comparison-core` package, replacing the generic `webdriver-image-comparison` module with a WDIO-specific solution. | ||
|
|
||
| #### What was the problem? | ||
|
|
||
| - The old `webdriver-image-comparison` package was designed for generic webdriver usage | ||
| - Complex integration between generic and WDIO-specific code | ||
| - Limited test coverage (~58%) making maintenance difficult | ||
| - Mixed responsibilities between core logic and service integration | ||
|
|
||
| #### What changed? | ||
|
|
||
| β **New dedicated core package**: `@wdio/image-comparison-core` - purpose-built for WebdriverIO | ||
| β **Cleaner architecture**: Modular design with clear separation of concerns | ||
| β **Enhanced test coverage**: Improved from ~58% to ~90% across all metrics | ||
| β **Better maintainability**: Organized codebase with comprehensive TypeScript interfaces | ||
| β **WDIO-specific dependencies**: Only depends on `@wdio/logger`, `@wdio/types`, etc. | ||
|
|
||
| ### π§ͺ Testing Improvements | ||
|
|
||
| - **100% branch coverage** on critical decision points | ||
| - **Comprehensive unit tests** for all major functions | ||
| - **Optimized mocks** for complex scenarios | ||
| - **Better test isolation** and reliability | ||
|
|
||
| | Before/After | % Stmts | % Branch | % Funcs | % Lines | | ||
| | ------------------ | ------- | -------- | ------- | ------- | | ||
| | **Previous** | 58.59 | 91.4 | 80.71 | 58.59 | | ||
| | **After refactor** | 90.55 | 96.38 | 93.99 | 90.55 | | ||
|
|
||
| ### π§ Service Integration | ||
|
|
||
| The `@wdio/visual-service` now imports from the new `@wdio/image-comparison-core` package while maintaining the same public API and functionality for users. | ||
|
|
||
| ### π Performance & Quality | ||
|
|
||
| - **Modular architecture**: Easier to maintain and extend | ||
| - **Type safety**: Comprehensive TypeScript coverage | ||
| - **Clean exports**: Well-defined public API | ||
| - **Internal interfaces**: Proper separation of concerns | ||
|
|
||
| ### π Backward Compatibility | ||
|
|
||
| β **No breaking changes** for end users | ||
| β **Same public API** maintained | ||
| β **Existing configurations** continue to work | ||
| β **All existing functionality** preserved | ||
|
|
||
| ### π― Future Benefits | ||
|
|
||
| This refactor sets the foundation for: | ||
|
|
||
| - Easier addition of new features | ||
| - Better bug fixing capabilities | ||
| - Enhanced mobile and native app support | ||
| - More reliable MultiRemote functionality | ||
|
|
||
| ### π¦ Dependency Updates | ||
|
|
||
| - Updated most dependencies to their latest versions | ||
| - Improved security with latest package versions | ||
| - Better compatibility with current WebdriverIO ecosystem | ||
| - Enhanced performance through updated dependencies | ||
| - Remove unused packages | ||
|
|
||
| *** | ||
|
|
||
| **Note**: This is an architectural improvement that modernizes the codebase while maintaining full backward compatibility. All existing functionality remains unchanged for users. | ||
|
|
||
| *** | ||
|
|
||
wswebcreation marked this conversation as resolved.
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.