Skip to content

Conversation

@itsisak
Copy link
Contributor

@itsisak itsisak commented Sep 11, 2025

Description

Removes the option to send contact forms anonymously

Testing

  • The code quality is at a minimum required level of quality, readability, and performance.
  • I have thoroughly tested my changes.

Updated the tests to match this new behavior

Related frontend pr: webkom/lego-webapp#5703

@itsisak itsisak requested review from a team and magnusbrecke September 11, 2025 13:33
@itsisak itsisak self-assigned this Sep 11, 2025
@itsisak itsisak added review-needed Pull requests that need review small-fix Pull requests that fix something small labels Sep 11, 2025
@codecov
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.00%. Comparing base (0a65e5e) to head (bfdc3c7).
⚠️ Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3842      +/-   ##
==========================================
- Coverage   90.01%   90.00%   -0.01%     
==========================================
  Files         765      765              
  Lines       24503    24480      -23     
==========================================
- Hits        22056    22033      -23     
  Misses       2447     2447              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@falbru falbru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great job!

@itsisak itsisak merged commit 7801052 into master Oct 11, 2025
5 checks passed
@itsisak itsisak deleted the remove-anonymous-contact-option branch October 11, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-needed Pull requests that need review small-fix Pull requests that fix something small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants