-
-
Notifications
You must be signed in to change notification settings - Fork 609
chore: update ESlint from v8 to v9 #1641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1641 +/- ##
==========================================
- Coverage 96.15% 89.74% -6.42%
==========================================
Files 10 10
Lines 1196 1199 +3
Branches 461 461
==========================================
- Hits 1150 1076 -74
- Misses 37 91 +54
- Partials 9 32 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8d1764d
to
9de965d
Compare
eslint.config.mjs
Outdated
export default defineConfig([ | ||
{ | ||
extends: [configs["recommended-dirty"]], | ||
ignores: ["*.md", "CHANGELOG.md", "README.md"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not ignore markdown files, except autogenerated, i.e. CHANGELOG.md, but it is already in default ignore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The npm run fix:js command has issues with markdown files, but the core functionality works
…h legacy peer deps
This PR contains a:
Motivation / Use-Case
update ESlint from v8 to v9
Breaking Changes
No
Additional Info
No