Apply changes from filter chip dropdowns immediately #2877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this resolves some user confusion around needing to close the dropdown before changes would be applied
this fixes an issue where every time filters were changed, another infinitely-repeating timeout was created, leading to long cascades of fetches in some cases.
SuaYoo
reviewed
Oct 6, 2025
frontend/src/features/archived-items/archived-item-state-filter.ts
Outdated
Show resolved
Hide resolved
frontend/src/features/crawl-workflows/workflow-profile-filter.ts
Outdated
Show resolved
Hide resolved
- remove redundant computed properties used as state, and instead track selected maps - replace `requestUpdate` calls with assignment to new `Map`s - use `updated` instead of `willUpdate` to dispatch events Co-authored-by: sua yoo <[email protected]>
SuaYoo
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR addresses some user feedback about filter chip dropdowns being confusing: specifically, about how when selecting a filter from a dropdown, it's not clear that you need to click outside the dropdown to apply the changes, leading to worries about user actions not being saved (see source in Discord).
This addresses this by changing filter chip behaviour to update its state (and re-fetch data) immediately when changes are made inside the dropdowns.
This also reworks the "schedule" filter chip in the workflow list page to show the selected option with a radio button so that it's more clear which state is selected and how switching states will work.
Finally, this addresses a bug in the archived item list where changing filters repeatedly would cause cascades of unnecessary re-fetches.
Demo
Screen.Recording.2025-10-02.at.3.24.59.PM.mov
Testing
On the workflow & archived item pages, try changing all of the filters, and make sure they all update & can be cleared (where relevant) as expected.