Fixed bug in PLAIN authentication support#1
Open
vponomarev wants to merge 1 commit intoweheartwebsites:masterfrom
vponomarev:master
Open
Fixed bug in PLAIN authentication support#1vponomarev wants to merge 1 commit intoweheartwebsites:masterfrom vponomarev:master
vponomarev wants to merge 1 commit intoweheartwebsites:masterfrom
vponomarev:master
Conversation
Member
|
Thanks @vponomarev a lot for your fix - I will have to add some unit + integration tests as this seems to have been working before? (not sure though). Please give me some time to set it up :) |
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.
I tried to use SOCKS5 proxy with PLAIN text authentication and found this issue.
Patch was tested with Dante SOCKS proxy server, everything works fine.