Add a cancellation token to AsyncMysqlConnection #258
Merged
+96
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this discussion (#4587 ) in the spring, I decided to go ahead and build a MySQL cancel token according to the basic design discussed. I hope taking a stab at this and opening a PR right away isn't premature or inappropriate.
I added some basic documentation and a test, although the test is a bit awkward: MySQL wouldn't reliably return an error for me when a query was cancelled, so I had to fall back to using the load method and checking the return integer. Also, I wasn't able to move an AsyncMysqlConnection between threads so I had it send the cancel token via a channel.
Let me know if there are any changes I should make or if I'm out of line here.