Use custom Future combinators to avoid GAT errors
#262
+154
−105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
stormshield-kg
force-pushed
the
fix-hrtb-errors
branch
2 times, most recently
from
45b9877 to
80233b7
Compare
|
Thanks for opening this PR. This is really great work. I spend some time to looking at this today as I'm not 100% happy to have these manual future implementations there. So far I've not been able to remove them, so maybe that's really the best possible solution. |
weiznich
force-pushed
the
fix-hrtb-errors
branch
from
80233b7 to
7c6c54b
Compare
This commit replaces the hand written future impls with such ones that wrap the types from futures-util. This hopefully reduces the complexity and also allows using the well tested types instead of hand written ones. I also removed the dependency on pin-project-light in favour of two lines of unsafe code as pin-project would do the same thing internally as well and these two instances are trivial to reason about.
weiznich
force-pushed
the
fix-hrtb-errors
branch
from
7c6c54b to
661de8c
Compare
weiznich
approved these changes
Oct 2, 2025
|
Thanks again for figuring this out ❤️ I did some refactoring to use the future combinators from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #249.
The compilation errors were caused by the lifetimes when using closures with
Futurecombinators in theRunQueryDsltrait.This PR fixes the GAT errors by redefining custom
Futurecombinators to limit closure usage.