Merged
Conversation
The only needed one is `local.wordpress_path` now. Other config are taken through - the now mandatory - wp-cli.
b30377c to
7f5df0e
Compare
Member
Author
|
I've also updated the |
nlemoine
reviewed
Jan 4, 2022
Contributor
|
This is awesome! Thanks so much for implementing all these new features 😃 I just left a tiny comment. |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is going to be merged into the 6.0 version branch.
This will bring a big feature: standing on the shoulder of the 6.0's mandatory peer dependency on wp-cli, we going to drop all the custom methods and configuration for the
localenvironment relative tolocal.vhostconfig in movefile.yml)All these actions and config will be done/get through wp-cli.
Now the only configuration we'll have for local environment will be
The goals of this feature are:
doctorcommand will still check for database config (user, password, etc.), erroring when actually we can't get those configs from wp-cli.portandmysqldump_optionsandmysql_optionsandcharsetdatabase configs are dropped: if you need to tweak around those, you'll need to do it the wordpress way (https://wordpress.org/support/article/editing-wp-config-php) and the wp-cli way (https://make.wordpress.org/cli/handbook/references/config/#config-files).Last but not the least: this branch will update ruby language support to the current stable version 3.0.2.
Nonetheless the vision steering this feature was endorsed in #601 . I'm not taking all the ideas from @nlemoine , but I'm looking at what I can afford to bring out of alpha within my winter holidays ^^"