build: bump minimum ruby version to 3.1.0 and fix various errors. #682
Open
AlextheYounga wants to merge 10 commits intowelaika:masterfrom
Open
build: bump minimum ruby version to 3.1.0 and fix various errors. #682AlextheYounga wants to merge 10 commits intowelaika:masterfrom
AlextheYounga wants to merge 10 commits intowelaika:masterfrom
Conversation
This change corrects an error due to bumping the Ruby version higher as newer Ruby versions load logger in a different order. You get uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger (NameError) errors in 3.1
This change corrects an error in wordmove doctor 'Wordmove::Doctor::Rsync#check!': undefined method '[]' for nil (NoMethodError).
This change corrects an ArgumentError that arises from passing in now obsolete arguments into YAML safeload.
This change just adds minor string concatenation changes and regex formatting changes in order to please the pig.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruby 2.6 is well past end-of-life and trying to support it means untangling a lot of brittle shims. Ruby 3.0 also reached EOL in April 2024, so requiring it would still leave you relying on an unsupported interpreter almost immediately.
Changes:
Potentially effects (or corrects) #679
All tests pass and some new tests were added.
I keep clean commits. Please see each commit to see each individual change.