Added a check to ensure that resolution is defined#114
Open
NathanSkene wants to merge 1 commit intowelch-lab:masterfrom
Open
Added a check to ensure that resolution is defined#114NathanSkene wants to merge 1 commit intowelch-lab:masterfrom
NathanSkene wants to merge 1 commit intowelch-lab:masterfrom
Conversation
Just had an error occur and this should stop it happening again. I had called: a.pbmc <- quantileAlignSNF(a.pbmc, resolution = res, small.clust.thresh = 20) However, I had forgotten to set 'res'. Because res does not get used until late in the function, it was 20 minutes or so until the function crashed. The lines I've added just check to ensure that res has been properly defined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just had an error occur and this should stop it happening again.
I had called:
a.pbmc <- quantileAlignSNF(a.pbmc, resolution = res, small.clust.thresh = 20)
However, I had forgotten to set 'res'. Because res does not get used until late in the function, it was 20 minutes or so until the function crashed. The lines I've added just check to ensure that res has been properly defined.