Open
Conversation
Collaborator
|
Hi Sam, Thank you for being our active user! Indeed I have found this a problem a while ago and have already got a fix in my dev branch. Would you mind have a look in my forked repo "mvfki/liger" in master branch and see if that looks like working fine? Best, |
Collaborator
|
So basically I got one more step before setting. If the defaultDimRed is set, don't update it by default unless explicitly asked with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi LIGER team,
Just quick PR here to fix issue. Right now runTSNE and runUMAP don't appropriately update the default dim reduc when a dimreduc is already present in object (for instance if seurat object with reductions is converted to liger object). This PR just adds single line to each of the functions to explicitly update the dim reduc after being run.
Thanks!
Sam