Skip to content

Changes tsne.coords Matrix slot to dr.coords list slot to store t-SNE and UMAP coords in the same object.#94

Open
jsodicoff wants to merge 2 commits intomasterfrom
tsne_umap
Open

Changes tsne.coords Matrix slot to dr.coords list slot to store t-SNE and UMAP coords in the same object.#94
jsodicoff wants to merge 2 commits intomasterfrom
tsne_umap

Conversation

@jsodicoff
Copy link
Collaborator

No description provided.

@vkozareva
Copy link
Collaborator

The build errors so far are due to old tests referring to the now nonexistent tsne.coords. Don't forget to update existing tests to be compatible with your new features (in this case, the new dr.coord slot)!
Also, many of the same notes from #89 apply here too -- make sure to check the build log.

@vkozareva
Copy link
Collaborator

Also, you'll need to merge master back into this feature branch and fix the merge conflicts indicated above!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants