Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove getClass() call - it was executed on Class and deleted any data #3033

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Remove getClass() call - it was executed on Class and deleted any data #3033

merged 2 commits into from
Aug 21, 2024

Conversation

dk2k
Copy link
Contributor

@dk2k dk2k commented Aug 19, 2024

No description provided.

@dk2k dk2k requested a review from manovotn as a code owner August 19, 2024 18:54
manovotn
manovotn previously approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manovotn manovotn dismissed their stale review August 21, 2024 13:04

Wrong review

@manovotn
Copy link
Contributor

LGTM

Actually I was wrong, the whole if-else condiiton seems to be wrong and only working by accident.
The if and else inner code is swapped - in case we detect the dummy class, we should use the dummy enum and not the other way around.
I will push some more changes into this PR.

@manovotn manovotn merged commit ffd8a83 into weld:master Aug 21, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manovotn manovotn manovotn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dk2k @manovotn